Hi Brian,
although I can't see a difference between your
for (p = linebuf; *p; ++p) {
if (*p == '#') {
*p = '\0';
- return;
+ continue;
}
}
modification and my first attempt (simply delete the "return;" and without
the "continue;"), it seems to be working (tested on 3 different clusters)
and I don't know why (should compile to identical object code). Until now I
did not discover the mistakes I made. Maybe it was just too late ...
Thanks you for your help and please forgive me my disability.
Regards,
Christian
> On Apr 17, 2006, at 1:19 PM, Christian Siebert wrote:
>
> > It is always good to have everything documented properly.
> > Unfortunately, a
> > comment in a hostfile (introduced by '#') skips the whole line and
> > not only
> > the rest of the line as it is stated in 'lam-7.1.2/share/boot/
> > bhostparse.c'.
> > I'd like to have this feature as specified and tried to correct it
> > by myself
> > (First, I thought it would be enough to just delete the
> > "superfluous" return
> > in line 447 in "lam-7.1.2/share/boot/bhostparse.c"). After several
> > hours of
> > unlucky modifications, I've given up and was hoping to get some
> > hints here.
>
> Doh! That definitely looks like a bug. Don't know how we let that
> one live for so long. I'm unfortunately in a conference all week and
> have limited testing access. I think the attached patch should fix
> the issue. Can you give it a try and let me know if it works for you?
>
>
> Thanks,
>
> Brian
>
> --
> Brian Barrett
> LAM/MPI developer and all around nice guy
> Have a LAM/MPI day: http://www.lam-mpi.org/
--
GMX Produkte empfehlen und ganz einfach Geld verdienen!
Satte Provisionen für GMX Partner: http://www.gmx.net/de/go/partner
|
